Plug some leaks in curl's proxy handling - #4359
Merged
Merged
Conversation
When we duplicate a user-provided options struct, we're stuck with freeing the url in it. In case we add stuff to the proxy struct, let's add a function in which to put the logic.
Member
Member
Author
|
I was looking at #4339 where the thread-unsafe suite seems to be failing somewhat reliably, but I've been unable to reproduce it. |
Member
|
Oh, that's interesting, isn't it. I hadn't seen that. |
pks-t
requested changes
Oct 6, 2017
| return 0; | ||
| } | ||
|
|
||
| void git_proxy_options_free(git_proxy_options *opts) |
Member
There was a problem hiding this comment.
We usually call this kind of function git_proxy_options_clear instead of free. A free should also free the structure itself.
Member
Author
There was a problem hiding this comment.
Sure, that makes sense. Done.
Member
|
Thanks @carlosmn ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to reproduce the segfault we see in Travis when talking to the proxy, but instead I found a few leaks.