You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's preferable to use target_include_directories instead of include_directories in modern CMake. It's also more consistent with target_link_libraries.
As of now, we cannot use the target_include_directories as it has only been introduced in CMake 2.8.12. While most current distros already have this version (Ubuntu Trusty, CentOS 6), there is at least the usual suspect of Debian, where Debian Wheezy only has v2.8.9. Furthermore, Travis currently still uses Ubuntu Precise, which has an older version, as well.
Can I use target_include_directories under if(${CMAKE_VERSION} VERSION_GREATER 2.8.12)? I really need it because I use libgit2 as subproject and this is rather awkward to add explicitly libgit2/include to include directories of my target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's preferable to use
target_include_directoriesinstead ofinclude_directoriesin modern CMake. It's also more consistent withtarget_link_libraries.