sysdir: don't re-guess when using variable substitution - #4034
Merged
Conversation
When given $PATH as part of a search path, we guess again instead of substituting what the user already set.
We should replace it with whatever the user set, not start again.
carlosmn
force-pushed
the
cmn/sysdir-no-reguess
branch
from
December 18, 2016 14:47
e826ed0 to
9f09f29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user sets a search path via variable substitution, we should replace the variable with whatever they may have previously set, rather than guess again what we would have chosen.