test: Fix stat() test to mask out unwanted bits - #3798
Merged
Conversation
Merged
Contributor
Author
|
Of course win32 doesn't know about the most basic POSIX constants: Should I patch src/posix.h ? |
Member
|
Neither does Linux or Mac, though. I don't think that's a POSIX thing, I think it's something Haiku invented. |
Contributor
Author
|
Oh, indeed, I didn't check other stat headers... Linux' sys/stat.h has an ALLPERMS but ifdeffed, so I'm not sure it's always available. And mingw headers don't seem to have it. I'll just hardcode it but it's ugly. |
Haiku and Hurd both pass extra bits in struct stat::st_mode.
Contributor
Author
|
Let's see this way... |
Contributor
Author
|
Looks like tests passed :) |
Member
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haiku and Hurd both pass extra bits in struct stat::st_mode.