CMake: activate the rpath policy for OSX - #3544
Closed
carlosmn wants to merge 1 commit into
Closed
Conversation
This activates the newer policy of using rpath in the build and shuts CMake up about it when we're building.
Member
|
Okay so, this shouldn't break anything. It will just generate relative paths for the linker to look in instead of using absolute paths (the default before this). I can't try this atm, but I'll look tomorrow to see what Looks good to me otherwise. |
Member
|
Okay, so I've just taken a look at this, luckily I stumbled upon it: This is what the linker path would look like. So, instead of looking for the identity library - aka libgit2 itself - in an absolute path /path/to/libgit2, and that wouldn't load libgit2 unless it was found in that path. tl;dr this won't hurt, 👍 |
Member
Author
|
OK, then we'd just need to make this version-dependent. |
Member
|
Closed via #4513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This activates the newer policy of using rpath in the build and shuts
CMake up about it when we're building.
/cc @Therzok I figure you'd at least know whether this impacts people trying to use the library.