don't double free pkt - #1947
Merged
Merged
Conversation
Member
Author
|
(Though it's pretty obviously a double-free sort of situation even without a unit test that causes a crash.) |
Member
|
Pretty sure what I meant to do there was only the |
Member
|
The only way this codepath would ever get triggered is during a non-clone fetch, where we have happened upon a set of haves that the remote has considered exhaustive enough for it to send the data, in which case it sends us |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
don't double free pkt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgit2sharp has a use case that exercises this code path, but I could not make it happen myself.
@nulltoken do you have any insight into how this got triggered in that test? I tried setting fetch specs to none, then to all, but it did not happen for me...!