Generate stringer files automatically - #841
Merged
Merged
Conversation
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Ticket: #543
lhchavez
reviewed
Nov 7, 2021
lhchavez
left a comment
Contributor
There was a problem hiding this comment.
yay, thanks for the CI addition!
Apply review comments about stringer workflow steps Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Contributor
Author
|
@lhchavez thanks for review! Please check new changes and answers. |
lhchavez
reviewed
Nov 8, 2021
Review fixes for workflow Co-authored-by: lhchavez <lhchavez@lhchavez.com>
lhchavez
reviewed
Nov 8, 2021
Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Contributor
Author
|
Exported |
lhchavez
approved these changes
Nov 8, 2021
lhchavez
left a comment
Contributor
There was a problem hiding this comment.
yay! now it works in CI!
thank you for this improvement :D
lhchavez
pushed a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338)
lhchavez
pushed a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338)
lhchavez
pushed a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338)
lhchavez
pushed a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338)
lhchavez
pushed a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338)
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338) Co-authored-by: Kirill <g4s8.public@gmail.com>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338) Co-authored-by: Kirill <g4s8.public@gmail.com>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338) Co-authored-by: Kirill <g4s8.public@gmail.com>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338) Co-authored-by: Kirill <g4s8.public@gmail.com>
lhchavez
added a commit
that referenced
this pull request
Nov 9, 2021
Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338) Co-authored-by: Kirill <g4s8.public@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
stringerannotations togit.goforErrorClassandErrorCode. Addedgeneraterule forMakefileto generatestring representations for these types (first building cgo files
in
_objdir to get C constants). Finally, updatedciactionsworkflow to check that generated files are up to date.
Fixes: #543