FetchOptions: add ability to specify ProxyOptions - #623
Merged
Conversation
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning.
lhchavez
reviewed
Jul 10, 2020
lhchavez
left a comment
Contributor
There was a problem hiding this comment.
nice, just two small requests.
Rather than embeding the ProxyOptions struct add a member to the struct. Also use a value rather than a pointer, so that the zero value of FetchOptions is well defined.
This is already preformed by git_fetch_init_options()
Contributor
Author
|
Thanks for the detailed feedback @lhchavez, I believe I have addressed both of your good suggestions, let me know if you what to see any additional changes, thanks! |
lhchavez
approved these changes
Jul 10, 2020
lhchavez
left a comment
Contributor
There was a problem hiding this comment.
let me know if you what to see any additional changes, thanks!
no additional changes needed. thanks!
lhchavez
pushed a commit
that referenced
this pull request
Aug 15, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Aug 15, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Aug 15, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Aug 15, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Aug 16, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Aug 16, 2020
Prior to this change you could not specifiy proxy options on the FetchOptions struct, which made it impossible to specify a proxy for an initial clone. This change adds the ProxyOptions to the FetchOptions struct so you can go through a proxy when cloning. (cherry picked from commit b1cad11)
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
Analog to #623 but for push operations rather than fetch.
This was referenced Jan 18, 2022
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
lhchavez
pushed a commit
that referenced
this pull request
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change you could not specifiy proxy options on the
FetchOptions struct, which made it impossible to specify a proxy for an
initial clone. This change adds the ProxyOptions to the FetchOptions
struct so you can go through a proxy when cloning.