Skip to content

CI: Support integration_tests for X86 and WASM_X86 backends - #1262

Merged
ubaidsk merged 7 commits into
lcompilers:mainfrom
ubaidsk:ci_x86
Nov 11, 2022
Merged

CI: Support integration_tests for X86 and WASM_X86 backends#1262
ubaidsk merged 7 commits into
lcompilers:mainfrom
ubaidsk:ci_x86

Conversation

@ubaidsk

@ubaidsk ubaidsk commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

This PR adds support for integration_tests for the x86 and wasm_x86 backends. There is a basic test case integration_tests/print_03.py (which just prints an integer 5) (temporarily) added to test if the generated x86 binary executes.

@ubaidsk ubaidsk changed the title CI: Support X86 integration_tests CI: Support integration_tests for X86 and WASM_X86 backends Nov 3, 2022
@ubaidsk
ubaidsk marked this pull request as ready for review November 3, 2022 17:03
@ubaidsk

ubaidsk commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator Author

This is ready. Please possibly review and please share feedback.

@ubaidsk
ubaidsk requested a review from certik November 3, 2022 17:03
@ubaidsk

ubaidsk commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator Author

It seems the generated x86 output file does not run on Mac, hence the macos CI test is failing, I think.

@certik please, could you possibly share what we should do?

@ubaidsk

ubaidsk commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator Author

Only the latest six commits are part of this PR. The rest of the commits are part of #1265.

@ubaidsk

ubaidsk commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator Author

Also, we are executing the integration_tests for x86 and wasm_x86 backends only on linux. Respective commit TEST: Execute integration_tests for x86 and wasm_x86 backends only on Linux.

@Smit-create

Copy link
Copy Markdown
Collaborator

We can wait on this till #1270 is merged so that we can re-use the code here.

@ubaidsk
ubaidsk force-pushed the ci_x86 branch 2 times, most recently from 8f8e367 to b07e0bb Compare November 10, 2022 18:26
@ubaidsk

ubaidsk commented Nov 11, 2022

Copy link
Copy Markdown
Collaborator Author

Rebased on top of latest main, resolved conflicts, adding it to auto-merge as it seems approved.

@ubaidsk
ubaidsk enabled auto-merge November 11, 2022 06:18
@ubaidsk
ubaidsk merged commit a025221 into lcompilers:main Nov 11, 2022
@ubaidsk
ubaidsk deleted the ci_x86 branch December 23, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants