test(changes follower): cover zero limit edge case - #5
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
test(changes follower): cover zero limit edge case#5devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adds
test_limit_zeroto bothTestChangesFollowerFiniteandTestChangesFollowerListen, covering the boundary of the existinglimitsfixture (100,_BATCH_SIZE,_BATCH_SIZE + 123) which never exerciseslimit=0.With
limit=0the follower takes a distinct path:_runclampsbatch_sizeto0and_ChangesFollowerIterator.__next__short-circuits onlimit == 0before consuming the buffer, so the iterator must stop cleanly (including joining the request thread) with zero changes even though the mocked feed hasMAX_BATCHESavailable. In LISTEN mode this is the only condition under which the feed terminates on its own withoutstop()or an error.Both tests use the shared
runnerwith a generous timeout, so a regression that hangs (e.g. blocking onQueue.get) or emits changes fails the assertion rather than passing vacuously.Fixes: n/a — test-only addition.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
limit=0is untested in both operating modes.What is the new behavior?
No production code changes; the zero-limit behaviour is now asserted for FINITE and LISTEN modes.
Does this PR introduce a breaking change?
Other information
python -m pytest test/unit/features/test_changes_follower.py(41 passed) andpython -m pylint --rcfile=.pylintrc ibmcloudant(10.00/10) pass locally.Link to Devin session: https://app.devin.ai/sessions/a8f6ece030764ec194d962c4552b83cf
Requested by: @eml2026