Skip to content

test: add ChangesFollower empty feed edge case test - #3

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787096739-changes-follower-empty-feed-test
Open

test: add ChangesFollower empty feed edge case test#3
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787096739-changes-follower-empty-feed-test

Conversation

@devin-ai-integration

Copy link
Copy Markdown

PR summary

Adds a unit test for an untested ChangesFollower edge case: a one-off (FINITE mode) run against a changes feed with zero pending changes. The first _changes response returns results: [] and pending: 0, and the test asserts the iterator terminates cleanly with zero changes instead of hanging or erroring. Existing FINITE tests all use at least one non-empty batch; this covers the pending == 0 fast-exit path in _ChangesFollowerIterator._request_callback on the very first request. Uses the existing runner helper with a timeout guard so a regression that hangs fails the test rather than blocking the suite.

Fixes: n/a (test-only addition)

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

No unit test covers a FINITE mode ChangesFollower run when the feed has no pending changes at all (empty database / already caught-up since sequence).

What is the new behavior?

test_start_one_off_empty_feed verifies that start_one_off() terminates immediately with zero changes when the first response has pending: 0 and empty results. All 40 tests in test_changes_follower.py pass and pylint remains 10.00/10.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

n/a

Link to Devin session: https://app.devin.ai/sessions/5abf9660e1f0483ab2e7f7094c58807f
Requested by: @eml2026

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@laveresteban laveresteban self-assigned this Aug 18, 2026
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant