test: add ChangesFollower empty feed edge case test - #3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
test: add ChangesFollower empty feed edge case test#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adds a unit test for an untested
ChangesFolloweredge case: a one-off (FINITE mode) run against a changes feed with zero pending changes. The first_changesresponse returnsresults: []andpending: 0, and the test asserts the iterator terminates cleanly with zero changes instead of hanging or erroring. Existing FINITE tests all use at least one non-empty batch; this covers thepending == 0fast-exit path in_ChangesFollowerIterator._request_callbackon the very first request. Uses the existingrunnerhelper with a timeout guard so a regression that hangs fails the test rather than blocking the suite.Fixes: n/a (test-only addition)
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
No unit test covers a FINITE mode
ChangesFollowerrun when the feed has no pending changes at all (empty database / already caught-up since sequence).What is the new behavior?
test_start_one_off_empty_feedverifies thatstart_one_off()terminates immediately with zero changes when the first response haspending: 0and emptyresults. All 40 tests intest_changes_follower.pypass and pylint remains 10.00/10.Does this PR introduce a breaking change?
Other information
n/a
Link to Devin session: https://app.devin.ai/sessions/5abf9660e1f0483ab2e7f7094c58807f
Requested by: @eml2026