Add Azure Active Directory Library to dependencies.#579
Merged
roycaihw merged 2 commits intokubernetes-client:masterfrom Jul 23, 2018
Merged
Add Azure Active Directory Library to dependencies.#579roycaihw merged 2 commits intokubernetes-client:masterfrom
roycaihw merged 2 commits intokubernetes-client:masterfrom
Conversation
roycaihw
reviewed
Jul 23, 2018
| websocket-client>=0.32.0,!=0.40.0,!=0.41.*,!=0.42.* # LGPLv2+ | ||
| requests # Apache-2.0 | ||
| requests-oauthlib # ISC | ||
| adal>=1.0.2 |
Member
There was a problem hiding this comment.
nit: document the license (# MIT) to be consistent with the other lines
Contributor
Author
|
Comment addressed, please re-check. Thanks! |
Member
|
/lgtm |
Contributor
I agree. another option is to make the python-base a library that added as requirements here instead of git-submodule but that means keeping two release process or a more complicated one that include releasing both packages together which can be worse. do you have any other suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support:
kubernetes-client/python-base#77
btw, git submodules are terrible... :(