Nikolai Romanov | oct2025-3 | Legacy code | Sprint 1 | Purple Forest: New Feature: Re-bloom - #3
Open
kolya-rm wants to merge 26 commits into
Open
Nikolai Romanov | oct2025-3 | Legacy code | Sprint 1 | Purple Forest: New Feature: Re-bloom#3kolya-rm wants to merge 26 commits into
kolya-rm wants to merge 26 commits into
Conversation
- wrong query selector, for get login component, "[data-action=''login]" replaced by "[data-form='logout']" - wrong event for login "click" replaced by "submit".
…ext length control. If inputed in the form text ovverides max length it will be short to max length.
…iew function. Because it invokes the state.updateState function which dispatchs "state-change" event. "state-change" event is listened by documend and is handled with the router.handleRouteChange function which after parsing window location hash calls the hashtag.hastagView function. Which leads to the infinite loop.
…quest if blooms with requested hashtag have got. In views/hashtag.hashtagView it comparates requested hashtage and saved in the state. If they equals it renders saved in the state blooms otherwise requested new blooms via apiService.
…ags. Replaced any non-hash symbol by any word symbol in regular expression used to find and replace hashtag.
- set isn't visible only for self profile; - added data-is-following attribute to store profile.is_following value; - added setting "Follow" "Unfollow" button text depending on profile.is_following value.
…leFollow to invoke the api service followUser function in case of user isn't followed and to invoke the unfollowUser function in case of user is followed.
… options object, contains the user to unfollow object.
- added the url rule for the application in the main.py handling /unfollow endpoint; - imlemented the do_unfollow function in the endpoints.py to handling an unfollow user request; - implemented the unfollow function in the follows.py to handle an unfollow request data in the database; - fixed unfollow request endpoint in the frontend side api.mjs unfollowUser function.
- original bloom id; - original bloom sender; - reblooms count.
- added original bloom id paramter in the function signature; - implemented insert the original bloom id in database; - implement return the added bloom.
- change the sender field type to str; - updated the add_bloom function signature, the User type sender parameter replaced with the int sender_id anst str sender_username parameters; - updated the add_bloom function invoke in the endpoints.py file.
…to get original bloom id, original bloom author usre name, reblooms count.
…ent handle reblooms.
… implement handling reblooms.
…th_hashtag functions in the blooms.py file.
… db request result into the blooms list. Replaced the repeated code in the get_blooms_for_user, get_bloom, get_blooms_with_hashtag with the new funcion invocation.
- fixed the parameter name in rebloom endpoint in the main.py file; - added missing comma in the get bloom db request; - fixed re-blooms count component name in the blooms.mjs; - exported reBloom function from the api.mjs module.
- fixed re-bloom element visibility setting; - fixed re-blooms count variable name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented new feature to re-bloom exist blooms:
Based on the coursework/feature-unfollow branch.
Questions
Ask any questions you have for your reviewer. You must remove this section if you have no questions.