Nikolai Romanov | oct2025-3 | Legacy code | Sprint 1 | Purple Forest: Bugfix - #1
Open
kolya-rm wants to merge 5 commits into
Open
Nikolai Romanov | oct2025-3 | Legacy code | Sprint 1 | Purple Forest: Bugfix#1kolya-rm wants to merge 5 commits into
kolya-rm wants to merge 5 commits into
Conversation
- wrong query selector, for get login component, "[data-action=''login]" replaced by "[data-form='logout']" - wrong event for login "click" replaced by "submit".
…ext length control. If inputed in the form text ovverides max length it will be short to max length.
…iew function. Because it invokes the state.updateState function which dispatchs "state-change" event. "state-change" event is listened by documend and is handled with the router.handleRouteChange function which after parsing window location hash calls the hashtag.hastagView function. Which leads to the infinite loop.
…quest if blooms with requested hashtag have got. In views/hashtag.hashtagView it comparates requested hashtage and saved in the state. If they equals it renders saved in the state blooms otherwise requested new blooms via apiService.
…ags. Replaced any non-hash symbol by any word symbol in regular expression used to find and replace hashtag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
the components/bloom.mjs
Questions