test(recovery): gate per-word BIP-39 validation at 7.15.1, as documented - #213
Closed
BitHighlander wants to merge 1 commit into
Closed
test(recovery): gate per-word BIP-39 validation at 7.15.1, as documented#213BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
The test's own docstring says the feature it exercises requires firmware 7.15.1+, but the gate admitted 7.15.0. Any 7.15.0 build therefore runs a test for behaviour that release is not expected to have: entering a word outside the BIP-39 wordlist returns a CharacterRequest for the next word rather than a Failure, and the assertion fails. No behaviour change -- the gate now matches the docstring beside it.
Contributor
Author
|
Closing: this suppresses a real signal rather than fixing a misgated test. The firmware genuinely lacks per-word BIP-39 validation during cipher recovery -- the handler clears decoded_word at a word boundary and advances without checking the wordlist, so an invalid word returns the next CharacterRequest instead of a Failure. The test is correct to fail; the docstring's "7.15.1+" is what misled me. The fix belongs in firmware: BitHighlander/keepkey-firmware#390 will carry the per-word validation so the test passes for the right reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test's own docstring says the feature it exercises requires firmware
7.15.1+, but the gate admitted 7.15.0. Any 7.15.0 build therefore runs a
test for behaviour that release is not expected to have: entering a word
outside the BIP-39 wordlist returns a CharacterRequest for the next word
rather than a Failure, and the assertion fails.
No behaviour change -- the gate now matches the docstring beside it.