June | Oct2025-1 | Structuring and Testing Data | Sprint 3 | Coursework - #3
Open
juneMonton wants to merge 11 commits into
Open
June | Oct2025-1 | Structuring and Testing Data | Sprint 3 | Coursework#3juneMonton wants to merge 11 commits into
juneMonton wants to merge 11 commits into
Conversation
added 11 commits
December 1, 2025 20:55
nsi88
suggested changes
Jan 16, 2026
nsi88
left a comment
There was a problem hiding this comment.
It looks good overall. Left some rather minor comments. But would be good to at least checking the comments before merging. Will mark as "request changes"
| // =============> write your explanation here : str has been declared in the function parameter and inside the function | ||
| // =============> write your new code here | ||
| function capitalise(str) { | ||
| return str `${str[0].toUpperCase()}${str.slice(1)}`; |
There was a problem hiding this comment.
The syntax in here doesn't seem valid. Is it intentional?
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| if (numerator < denominator) return true; | ||
| if (Math.abs(numerator)< denominator) return true;// Use absolute value for negative numerators |
There was a problem hiding this comment.
Do we need to handle the case with negative denominator?
There was a problem hiding this comment.
if (condition) { return true } else { return false } is considered a "bad taste" in programming.
It's better to write return condition in this case
|
|
||
| // Handle Ace (A) | ||
| // Given a card with rank "A", return 11 | ||
| if (rank === "A") return 11; |
There was a problem hiding this comment.
I recommend to use auto-formatting. Otherwise the indentations are all over the place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR is for Sprint-3 Testing answers
Questions
Please guide me on regarding testing, when and how was it used in real working environment