Ensure we have a classloader to boot from#9298
Merged
headius merged 2 commits intojruby:masterfrom Mar 10, 2026
Merged
Conversation
3b50823 to
50aee23
Compare
If JRuby is loaded in the bootstrap classloader, the direct getClassLoader for a Class object might return null. Use the alternative Ruby.getClassLoader instead which will fall back on the standard system classloader.
This adds a simpler path for classloader-based loading of files when we just want to get the system classloader resources shipped with JRuby. This will reduce the chance of someone using an improper classloader (e.g. JRubyLibrary might have loaded the wrong file from a JRubyClassLoader rather than the one shipped with JRuby) or stumbling on to a null classloader (as sometimes happened to the loads from javasupport.Java when running in a bootstrap classloader).
50aee23 to
45189cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If JRuby is loaded in the bootstrap classloader, the direct getClassLoader for a Class object might return null. Use the alternative Ruby.getClassLoader instead which will fall back on the standard system classloader.