Use live counts for event hook stats#9277
Merged
headius merged 1 commit intojruby:masterfrom Mar 1, 2026
Merged
Conversation
In CRuby, the deleted count in the stats appears to indicate those hooks that have been slated for removal from the hook list but not yet actually removed. JRuby actively removes the hook immediately when requested, so this deleted count is not really accurate. The added count is all the other hooks in the list that have not been slated for removal, and should be calculated live from that list. Tracking these values separately is error prone and we did not really represent deleted the way it seems to be used in CRuby.
4f8a7c9 to
05bf660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CRuby, the deleted count in the stats appears to indicate those hooks that have been slated for removal from the hook list but not yet actually removed. JRuby actively removes the hook immediately when requested, so this deleted count is not really accurate.
The added count is all the other hooks in the list that have not been slated for removal, and should be calculated live from that list.
Tracking these values separately is error prone and we did not really represent deleted the way it seems to be used in CRuby.