Skip to content

Fix for cloned class singleton class has too many ancestors#9239

Merged
headius merged 1 commit intojruby:ruby-4.0from
evaniainbrooks:9238-singleton-ancestors
Feb 18, 2026
Merged

Fix for cloned class singleton class has too many ancestors#9239
headius merged 1 commit intojruby:ruby-4.0from
evaniainbrooks:9238-singleton-ancestors

Conversation

@evaniainbrooks
Copy link
Copy Markdown
Contributor

@evaniainbrooks evaniainbrooks commented Feb 15, 2026

issue #9238

@evaniainbrooks evaniainbrooks marked this pull request as ready for review February 16, 2026 00:08
@headius
Copy link
Copy Markdown
Member

headius commented Feb 18, 2026

Looks right. Regressions in JRuby tests are due to an inspect change I made that does not appear to be necessary after this fix. I'll sort it out.

@headius headius added this to the JRuby 10.1.0.0 milestone Feb 18, 2026
@headius headius merged commit 0823d6e into jruby:ruby-4.0 Feb 18, 2026
45 of 79 checks passed
headius added a commit that referenced this pull request Feb 18, 2026
@headius
Restore overridden to_s call
b42564d 
The infinite recursion happening before seems to have been a side
effect of adding too many metaclasses into the hierarchy when
getting the singleton class of a class (see #9238, fixed
by #9239).
@headius headius mentioned this pull request Feb 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 10.1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@evaniainbrooks @headius