Skip to content

Add ruby_bug for spec of Data with no members being frozen#9209

Merged
headius merged 2 commits intojruby:ruby-4.0from
herwinw:spec_data_initialize
Feb 3, 2026
Merged

Add ruby_bug for spec of Data with no members being frozen#9209
headius merged 2 commits intojruby:ruby-4.0from
herwinw:spec_data_initialize

Conversation

@herwinw
Copy link
Copy Markdown
Contributor

@herwinw herwinw commented Feb 3, 2026

This makes the spec pass on Ruby 4.0.0 and earlies as well. This saves some issues with the next spec sync.

This makes the spec pass on Ruby 4.0.0 and earlies as well. This saves
some issues with the next spec sync.
The style `.should.predicate?` is slightly more idiomatic, and seems to
be preferred (see ruby/mspec#80 for a related
discussion).
@herwinw
Copy link
Copy Markdown
Contributor Author

herwinw commented Feb 3, 2026

This relates to #9202

@headius
Copy link
Copy Markdown
Member

headius commented Feb 3, 2026

This looks fine to me. Using ruby_bug for a teeny version is not common but it is done in a couple of places.

@headius headius added this to the JRuby 10.1.0.0 milestone Feb 3, 2026
@headius headius merged commit e3be698 into jruby:ruby-4.0 Feb 3, 2026
56 of 77 checks passed
@herwinw herwinw deleted the spec_data_initialize branch February 4, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants