Ajax: Support null as success functions in jQuery.get#5139
Merged
Conversation
Member
Author
|
I added this to the discussion list to discuss whether we want this in |
According to the docs, one can use `null` as a success function in `jQuery.get` of `jQuery.post` so the following: ```js await jQuery.get( "https://httpbin.org/json", null, "text" ) ``` should get the text result. However, this shortcut hasn't been working so far. Fixes jquerygh-4989
d75d41e to
aa17bef
Compare
null & undefined as success functions in jQuery.getnull as success functions in jQuery.get
mgol
commented
Oct 15, 2022
| if ( typeof data === "function" ) { | ||
| // Shift arguments if data argument was omitted. | ||
| // Handle the null callback placeholder. | ||
| if ( typeof data === "function" || data === null ) { |
Member
Author
There was a problem hiding this comment.
@gibson042 allowing undefined here would break the 4-param signature with the second parameter (data) being undefined which is e.g. used in the $.getScript definition. We could add more checks to make it work but I thought in that case it may be better to just allow null. null is not an allowed data value so we don’t have a conflict.
mgol
commented
Oct 15, 2022
| jQuery.ajaxTransport( function( options ) { | ||
| var callback; | ||
|
|
||
| // Cross domain only allowed if supported through XMLHttpRequest |
Member
Author
There was a problem hiding this comment.
This is unrelated but this comment has long been invalid… We only have support checks on 3.x-stable here.
gibson042
approved these changes
Oct 17, 2022
| if ( typeof data === "function" ) { | ||
| // Shift arguments if data argument was omitted. | ||
| // Handle the null callback placeholder. | ||
| if ( typeof data === "function" || data === null ) { |
Member
|
Since this has been like this for so long, we're going to leave 3.x unchanged and fix this for 4.0. |
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Oct 17, 2022
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
Member
Author
|
I submitted the API PR at jquery/api.jquery.com#1208. |
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Nov 18, 2022
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Nov 18, 2022
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Nov 18, 2022
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Oct 27, 2023
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Nov 6, 2023
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Oct 14, 2024
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Mar 24, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Apr 1, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Apr 14, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
May 5, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Ref jquery/jquery#4989 Ref jquery/jquery#5139
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
May 12, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Closes jquerygh-1208 Ref jquery/jquery#4989 Ref jquery/jquery#5139 Ref jquery/jquery#5640 Ref jquery/jquery#5645 Ref jquery/jquery#5646
mgol
added a commit
to jquery/api.jquery.com
that referenced
this pull request
May 12, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Closes gh-1208 Ref jquery/jquery#4989 Ref jquery/jquery#5139 Ref jquery/jquery#5640 Ref jquery/jquery#5645 Ref jquery/jquery#5646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to the docs, one can use
nullas a success function injQuery.getof
jQuery.postso the following:should get the text result. However, this shortcut hasn't been working so far.
Fixes gh-4989
Checklist
data: nullwith 3 params api.jquery.com#1208