Selector: Port Sizzle tests to jQuery#4406
Merged
Merged
Conversation
3 tasks
d3a7cab to
d459aad
Compare
Member
Author
|
I ported many more tests, pushed in new commits. Still a lot to go but we're getting closer. |
Member
Author
|
I added a few more commits. It's not 100% ready yet but it's close so I'd appreciate a review. I'll finish remaining pieces & address feedback when I'm back from vacation. |
Member
|
This is a lot to review. Honestly, I'm okay with merging when you feel it is ready and then we can increment in smaller PRs from there. |
Member
Author
|
As discussed at the meeting today, I'll merge it soon (tomorrow or on Wednesday) unless someone wants to have a look. Some final remarks/questions from me (you can review them instead if you want):
|
Apart from porting most Sizzle tests to jQuery (mostly to its selector module), this commit fixes selector-native so that a jQuery custom compilation that excludes Sizzle passes all tests as well.
22ad604 to
2dda538
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports Sizzle tests to jQuery. Reviewing by commit might be the best. Sizzle tests are located in three files named
extending.js,utilities.js&selector.js. TODO list:extending.js: these are only tests for custom pseudos which we'll be removing so I haven't backported them.utilities.js: I backported everything that wasn't already present with the exception ofSizzle.attra.k.a.jQuery.find.attr. This is an internal API & I think jQuery attribute tests are thorough enough that we don't need to add these tests. Let me know if you disagree.selector.js.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com