Build: Fix unresolved jQuery reference in finalPropName#4361
Merged
Conversation
Also, prevent further similar breakages by changing our ESLint configuration to disallow relying on a global jQuery object in AMD modules. Fixes jquerygh-4358
timmywil
approved these changes
Apr 17, 2019
Member
timmywil
left a comment
There was a problem hiding this comment.
LGTM, glad we could add this to lint.
Member
Author
|
This is quite small & I need it for another PR so I'll just land it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also, prevent further similar breakages by changing our ESLint configuration
to disallow relying on a global jQuery object in AMD modules.
Fixes gh-4358
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com