Skip to content

Fix install.ps1 crash when piped through iex and render in PowerShell 5.1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix install.ps1 crash when piped through iex and render in PowerShell 5.1 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c69d15
Fix install.ps1 crash when piped through iex and render in PS 5.1
devin-ai-integration[bot] May 11, 2026
fef59d4
Check git fetch/reset exit codes in source-build fallback
devin-ai-integration[bot] May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 60 additions & 11 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,42 @@ param(

$ErrorActionPreference = 'Stop'

# Render UTF-8 box-drawing glyphs correctly on Windows PowerShell 5.1's
# default OEM code page console.
try { [Console]::OutputEncoding = [System.Text.Encoding]::UTF8 } catch {}

# Resolve a repo checkout next to the running script. `$PSScriptRoot` is empty
# when the script is piped through `iex`, so guard every consumer with this
# helper rather than calling `Join-Path $PSScriptRoot ...` directly.
function Get-LocalCheckoutDir {
if (-not [string]::IsNullOrEmpty($PSScriptRoot)) { return $PSScriptRoot }
if ($PSCommandPath) {
$parent = Split-Path -Parent $PSCommandPath
if (-not [string]::IsNullOrEmpty($parent)) { return $parent }
}
if ($MyInvocation -and $MyInvocation.MyCommand -and $MyInvocation.MyCommand.Path) {
$parent = Split-Path -Parent $MyInvocation.MyCommand.Path
if (-not [string]::IsNullOrEmpty($parent)) { return $parent }
}
return $null
}

$Repo = 'johnesecat/hackcode-main'
$InstallDir = Join-Path $env:LOCALAPPDATA 'Programs\HackCode'
$BinaryPath = Join-Path $InstallDir 'hackcode.exe'
$ConfigDir = Join-Path $env:APPDATA 'hackcode'
$SrcDir = Join-Path $env:USERPROFILE '.hackcode-src'

# ─── Pretty printing ───────────────────────────────────────
$Green = "`e[38;2;0;255;65m"
$Dim = "`e[90m"
$Bold = "`e[1m"
$Red = "`e[91m"
$Nc = "`e[0m"
# `e is only an ESC literal in PowerShell 6+. Build it explicitly so the
# colors render in stock Windows PowerShell 5.1 too (Win10/11 ConsoleHost
# supports virtual-terminal sequences when ANSI is emitted directly).
$ESC = [char]27
$Green = "$ESC[38;2;0;255;65m"
$Dim = "$ESC[90m"
$Bold = "$ESC[1m"
$Red = "$ESC[91m"
$Nc = "$ESC[0m"

function Write-Banner {
Write-Host ''
Expand Down Expand Up @@ -180,16 +204,41 @@ if (-not $installed) {
}

# If we're already inside a checkout, build right here. Otherwise clone
# to a per-user source dir and build from there.
$localManifest = Join-Path $PSScriptRoot 'rust\Cargo.toml'
if (Test-Path $localManifest) {
$buildDir = Join-Path $PSScriptRoot 'rust'
} else {
# to a per-user source dir and build from there. When piped through `iex`
# there is no script directory, so the helper returns $null and we fall
# straight through to the clone path.
$checkoutDir = Get-LocalCheckoutDir
$buildDir = $null
if ($checkoutDir) {
$localManifest = Join-Path $checkoutDir 'rust\Cargo.toml'
if (Test-Path $localManifest) {
$buildDir = Join-Path $checkoutDir 'rust'
}
}
if (-not $buildDir) {
if (-not (Test-Command 'git')) {
Fail 'git is required to fetch HackCode source.'
Info 'Install with `winget install Git.Git` or download from https://git-scm.com/download/win, then re-run this installer.'
throw 'git not available'
}
if (Test-Path (Join-Path $SrcDir '.git')) {
git -C $SrcDir pull --quiet 2>$null | Out-Null
Info "Updating existing source checkout at $SrcDir"
git -C $SrcDir fetch --quiet origin 2>$null | Out-Null
$fetchExit = $LASTEXITCODE
if ($fetchExit -ne 0) {
Info "git fetch failed (exit code $fetchExit); building from existing checkout"
}
git -C $SrcDir reset --quiet --hard origin/HEAD 2>$null | Out-Null
Comment on lines +226 to +231

@devin-ai-integration devin-ai-integration Bot May 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing error check after git fetch / git reset allows silent build from stale source

The new git fetch + git reset --hard origin/HEAD path (lines 226-227) suppresses all output and stderr (2>$null | Out-Null) but never checks $LASTEXITCODE. If git fetch fails (e.g., network error), git reset --hard origin/HEAD will silently succeed by resetting to whatever was last fetched — potentially very outdated code. The script then proceeds to build and install that stale version without any warning. This is inconsistent with the git clone path at install.ps1:232-234, where $LASTEXITCODE is properly checked and an error is thrown on failure.

Suggested change
git -C $SrcDir fetch --quiet origin 2>$null | Out-Null
git -C $SrcDir reset --quiet --hard origin/HEAD 2>$null | Out-Null
git -C $SrcDir fetch --quiet origin 2>$null | Out-Null
if ($LASTEXITCODE -ne 0) {
Info "git fetch failed (exit code $LASTEXITCODE); building from existing checkout"
}
git -C $SrcDir reset --quiet --hard origin/HEAD 2>$null | Out-Null
if ($LASTEXITCODE -ne 0) {
throw "git reset failed with exit code $LASTEXITCODE"
}
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

if ($LASTEXITCODE -ne 0) {
throw "git reset failed with exit code $LASTEXITCODE"
}
} else {
if (Test-Path $SrcDir) { Remove-Item $SrcDir -Recurse -Force }
Info "Cloning https://github.com/$Repo.git into $SrcDir"
git clone --quiet "https://github.com/$Repo.git" $SrcDir
if ($LASTEXITCODE -ne 0) {
throw "git clone failed with exit code $LASTEXITCODE"
}
}
$buildDir = Join-Path $SrcDir 'rust'
}
Expand Down