Normalizing parameters duplicated in URL query string and POST parameters - #197
Conversation
|
Thanks @arthurian :) The issue with duplicated parameters is that it's up to the receiving server to determine how to deal with the url. We discussed a similar case in regards to arrays in urls. In which case the current implementation would end up looking like an array to some web servers, potentially breaking it. So from my perspective this pull request is definitely needed. How I personally think this should be implemented is similar to the way PHP populates it's @joestump @rickhanlonii what are your thoughts? |
|
Any news on this? Would be nice if merged :-) |
|
I've confirmed this merge and we'll see how it goes! |
|
Can you publish a new release on pypi that includes this? |
This PR modifies the merging of POST parameters with URL query parameters in
get_normalized_parameters()so that duplicate parameters (same key/value) are not duplicated in the normalized base string.I could not find any guidance on this issue from RFC 5849. Thoughts?
Note: per @jaitaiwan's request, I've closed #195 and reopened it here so that it's compared to develop instead of master.