Add query to InsufficientParametersException#418
Merged
oshai merged 3 commits intojasync-sql:masterfrom Nov 8, 2023
kennethtiller:add_query_to_insufficient_parameters_exception
Merged
Add query to InsufficientParametersException#418oshai merged 3 commits intojasync-sql:masterfrom kennethtiller:add_query_to_insufficient_parameters_exception
oshai merged 3 commits intojasync-sql:masterfrom
kennethtiller:add_query_to_insufficient_parameters_exception
Conversation
Contributor
|
Thanks for the PR! can you please add a test for it? |
Contributor
Author
Thanks for asking! I found it to be a natural fit for the existing tests, have a look and let me know if you'd like it another way |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds query to InsufficientParametersException, to include the SQL in the exception message.
This makes it easier to find what code has failed with insufficient parameters by searching for the query in client codebase.
It can be hard to find the code because the asynchronous nature of the library does not include stacktrace to call site.