Allow supplying ABI from command line override - #3902
Open
pljones wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Android qmake configuration so developers can override the Android ABI list from the command line (e.g., to build a single ABI locally) while keeping the existing “build all ABIs” behavior as the default.
Changes:
- Only assigns the default
ANDROID_ABISlist whenANDROID_ABISis empty. - Preserves existing Android version name/code settings and downstream uses of
ANDROID_ABIS(e.g., distclean per-ABI directories).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ann0see
reviewed
Aug 15, 2026
ann0see
left a comment
Member
There was a problem hiding this comment.
Can't test this, but I'd say it is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
When I'm doing a build locally, rather than have to build all the android platforms, it's useful to be able to specify which ABI to target. Currently,
Jamulus.proprevents this by directly setting the ABIs to build.This small change first checks whether any target is set and only sets it to the default list if it's empty.
CHANGELOG: SKIP
Context: Fixes an issue?
Useful enhancement to local build tooling.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested locally.
What is missing until this pull request can be merged?
Confirmation I'm not missing something.
Checklist
AUTOBUILD: Please build all targets