Paris - Yang - #363
Closed
yangyangzouzou wants to merge 2 commits into
Closed
Conversation
| } else if (hecker1.charAt(0) < hecker2.charAt(0)) { | ||
| console.log("Yo, the navigator goes first definitely") | ||
| } else { | ||
| console.log("What?! You both got the same name?") |
There was a problem hiding this comment.
c'est bien d'avoir pensé a charAt, c'est une bonne methode mais je t'invite a regarder la methode localCompare() qui correspond mieux a l'exercice ;)
|
|
||
| //loops | ||
|
|
||
| var DriversNames = ''; |
There was a problem hiding this comment.
Attention ! En JavaScript on utilise le camelCase, ce qui veut dire que lorsque tu declare une variable la premiere lettre est toujours une minuscule, puis si il ya un second mot et plus il y aura une majuscule: driversName. Ca n'empeche pas le code de fonctionner mais c'est une bonne habitude a prendre !
|
|
||
| var DriversNames = ''; | ||
| for (i=0; i<hecker1.length; i++) { | ||
| DriversNames += hecker1[i].toUpperCase |
There was a problem hiding this comment.
Attention ! Si tu utilises la methode toUpperCase() n'oublie pas les parentheses ! Sinon ERROR
|
C'est bien ! Continue comme ca ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.