Moving unpack_models to widget.js#8251
Merged
minrk merged 1 commit intoipython:masterfrom Apr 6, 2015
Merged
Conversation
Member
Author
Member
|
Makes sense to me. |
681ff56 to
d5abbaa
Compare
Member
Author
|
Just rebased and also moved the python side widget serialization to widget.py |
d5abbaa to
3afdea4
Compare
minrk
added a commit
that referenced
this pull request
Apr 6, 2015
Moving unpack_models to widget.js
Contributor
|
Thanks @SylvainCorlay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since every custom widget having child widgets will need the
unpack_modelfunction, introduced in #7757.It could probably be in
widget.jsrather than inwidget_box.js, especially since widget.js is already where ViewList is defined.