-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(range): add classes to the range when the value is at the min or max #30932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature-8.8
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Great work — thank you for this improvement! I noticed one potential limitation: since Two possible options could be:
ex: &:not(.dual-knobs).range-pressed {
&.range-value-min::part(knob) {}
&.range-value-max::part(knob) {}
}
&.dual-knobs.range-pressed {
&.range-value-min::part(knob-a) {}
&.range-value-max::part(knob-b) {}
}Either of these would greatly expand how this can be leveraged. |
|
Thank you for the feedback @rdlabo! I am actually working on adding |
|
This is a fantastic improvement — it really expands the customization possibilities a lot. 🙌 |
Issue number: N/A
What is the current behavior?
Range adds classes to the knobs at
minandmax, but the host element doesn't reflect those states.What is the new behavior?
range-value-minandrange-value-maxwhen the value is at theminormax, respectively.Does this introduce a breaking change?
Other information
Dev build:
8.7.17-dev.11768943212.1b316931