Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

feat: add model family in cfg - #3255

Merged
mergify[bot] merged 2 commits into
instructlab:mainfrom
jaideepr97:model-family-in-cfg
Apr 11, 2025
Merged

feat: add model family in cfg#3255
mergify[bot] merged 2 commits into
instructlab:mainfrom
jaideepr97:model-family-in-cfg

Conversation

@jaideepr97

@jaideepr97 jaideepr97 commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

adds the ability to pass a specific model-id to generate, chat and serve. This model id is then resolved out of the config if found, and details like the model-family, path etc are extracted and passed further
This is required to support 3rd party models being used as students, teachers etc in an easy way. The model family value is passed into sdg and appropriate chat template is selected based on what is passed

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 2, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from fd8f505 to f03672e Compare April 2, 2025 17:10
@mergify mergify Bot added testing Relates to testing dependencies Relates to dependencies ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 2, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from f03672e to 9221c50 Compare April 2, 2025 17:24
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 2, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 9221c50 to 5fe5d83 Compare April 2, 2025 17:30
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 2, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 5fe5d83 to f54f607 Compare April 2, 2025 17:42
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 2, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from f54f607 to 0b55bf3 Compare April 7, 2025 15:39
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 7, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 0b55bf3 to 6ccd1cd Compare April 8, 2025 15:34
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 8, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 6ccd1cd to 8681f1e Compare April 8, 2025 18:27
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 8, 2025
@jaideepr97
add model family in cfg
5eb6edf 
Signed-off-by: Jaideep Rao <jrao@redhat.com>
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 8681f1e to ffebea4 Compare April 10, 2025 18:20
@mergify mergify Bot added documentation Improvements or additions to documentation ci-failure PR has at least one CI failure labels Apr 10, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from ffebea4 to dc8f7ea Compare April 10, 2025 18:33
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 10, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from dc8f7ea to 94ba0ff Compare April 11, 2025 13:39
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 11, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 94ba0ff to 90422f7 Compare April 11, 2025 13:45
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 11, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 90422f7 to 60eb3bd Compare April 11, 2025 15:22
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 11, 2025
booxter
booxter suggested changes Apr 11, 2025
View reviewed changes
Comment thread src/instructlab/cli/data/generate.py Outdated
Comment thread src/instructlab/configuration.py Outdated
Comment thread src/instructlab/configuration.py Outdated
Comment thread src/instructlab/cli/model/serve.py
Comment thread tests/test_lab_generate.py Outdated
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 60eb3bd to b93b666 Compare April 11, 2025 17:31
booxter
booxter reviewed Apr 11, 2025
View reviewed changes
Comment thread tests/test_model_chat.py Outdated
booxter
booxter reviewed Apr 11, 2025
View reviewed changes
Comment thread tests/test_model_chat.py Outdated
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 11, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from b93b666 to 0d3a521 Compare April 11, 2025 18:21
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 11, 2025
RobotSail
RobotSail approved these changes Apr 11, 2025
View reviewed changes

@RobotSail RobotSail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on this @jaideepr97

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Apr 11, 2025
@RobotSail
RobotSail requested a review from booxter April 11, 2025 18:49
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Apr 11, 2025
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from 0d3a521 to dbfd4bb Compare April 11, 2025 18:59
@mergify mergify Bot removed the ci-failure PR has at least one CI failure label Apr 11, 2025
booxter
booxter reviewed Apr 11, 2025
View reviewed changes
Comment thread src/instructlab/cli/model/serve.py Outdated
Comment thread src/instructlab/cli/model/chat.py
cdoern
cdoern approved these changes Apr 11, 2025
View reviewed changes

@cdoern cdoern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the few nits left over, LGTM

@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Apr 11, 2025
@jaideepr97
add unit tests
9496ea7 
Signed-off-by: Jaideep Rao <jrao@redhat.com>
@jaideepr97
jaideepr97 force-pushed the model-family-in-cfg branch from dbfd4bb to 9496ea7 Compare April 11, 2025 21:31
booxter
booxter approved these changes Apr 11, 2025
View reviewed changes

@booxter booxter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the comments. This looks ready.

@mergify
mergify Bot merged commit b0cfe6b into instructlab:main Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@RobotSail RobotSail RobotSail approved these changes
@booxter booxter booxter approved these changes
@cdoern cdoern cdoern approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Relates to dependencies documentation Improvements or additions to documentation testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaideepr97 @booxter @cdoern @RobotSail