Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

fea: RAG functional tests - #3059

Closed
dmartinol wants to merge 14 commits into
instructlab:mainfrom
dmartinol:fix_3033
Closed

fea: RAG functional tests#3059
dmartinol wants to merge 14 commits into
instructlab:mainfrom
dmartinol:fix_3033

Conversation

@dmartinol

Copy link
Copy Markdown
Contributor

Adds RAG workflow to functional tests for all the managed paths:

  • from user documents
  • from taxonomy files
  • from processed taxonomy files

Testing logic emulates the e2e-custom.sh script defined in PR #2948, with changes specific to the functional test environment.

Notes:

  • This change has an impact on the overall execution tim of the functional tests, because it runs an additional ilab data generate command to process the knowledge documents.
  • The test temporarily overrides the required env var to enable the RAG feature and runs on every CI execution: this is the main difference from the e2e-custom.sh script that instead runs from a custom job.

Issue resolved by this Pull Request:
Resolves #3033

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

dmartinol and others added 11 commits January 29, 2025 11:49
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added the testing Relates to testing label Jan 29, 2025
@dmartinol dmartinol changed the title Fix 3033 fea: RAG functional tests Jan 29, 2025
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Jan 29, 2025
…ironment

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added CI/CD Affects CI/CD configuration and removed ci-failure PR has at least one CI failure labels Jan 30, 2025
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 30, 2025
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Feb 5, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions Bot added the stale label Apr 10, 2025
@booxter

booxter commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

@dmartinol any plans to get this in? If not, let's close it.

@dmartinol

Copy link
Copy Markdown
Contributor Author

I haven't seen much interest in this topic, so I think we can close it. The same is probably true for the PR aiming to add CI tests: #2948

@dmartinol dmartinol closed this May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure stale testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RAG][Testing] Add functional tests for embedding models

2 participants