Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

fea: Functional tests for RAG - #3051

Closed
dmartinol wants to merge 10 commits into
instructlab:mainfrom
dmartinol:fix_3033
Closed

fea: Functional tests for RAG#3051
dmartinol wants to merge 10 commits into
instructlab:mainfrom
dmartinol:fix_3033

Conversation

@dmartinol

@dmartinol dmartinol commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Adds RAG workflow to functional tests for all the managed paths:

  • from user documents
  • from taxonomy files
  • from processed taxonomy files

Testing logic emulates the e2e-custom.sh script defined in PR #2948, with changes specific to the functional test environment.

Notes:

  • This change has an impact on the overall execution tim of the functional tests, because it runs an additional ilab data generate command to process the knowledge documents.
  • The test temporarily overrides the required env var to enable the RAG feature and runs on every CI execution: this is the main difference from the e2e-custom.sh script that instead runs from a custom job.

Issue resolved by this Pull Request:
Resolves #3033

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol dmartinol changed the title functional tests for RAG fea: Functional tests for RAG Jan 29, 2025
@mergify mergify Bot added testing Relates to testing ci-failure PR has at least one CI failure labels Jan 29, 2025
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 29, 2025
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 29, 2025
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added the CI/CD Affects CI/CD configuration label Jan 29, 2025
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 29, 2025
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 29, 2025
@mergify mergify Bot closed this in #3054 Jan 29, 2025
@mergify mergify Bot closed this in ac7cc07 Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RAG][Testing] Add functional tests for embedding models

1 participant