This repository was archived by the owner on Apr 23, 2026. It is now read-only.
refactor: Tighten process registry interface - #3050
Merged
Merged
Conversation
booxter
force-pushed
the
general-process-cleanup
branch
from
January 29, 2025 04:02
ea40b5e to
d584136
Compare
booxter
force-pushed
the
general-process-cleanup
branch
from
January 29, 2025 04:15
d584136 to
d76636f
Compare
booxter
force-pushed
the
general-process-cleanup
branch
2 times, most recently
from
January 29, 2025 14:27
e6bb91a to
6347f57
Compare
booxter
commented
Jan 30, 2025
cdoern
reviewed
Jan 31, 2025
cdoern
left a comment
Contributor
There was a problem hiding this comment.
generally, nothing stands out here that I would correct. This looks like a really good refactoring of the process code. Besides that one bug which you already caught
booxter
force-pushed
the
general-process-cleanup
branch
from
January 31, 2025 17:01
6347f57 to
a2ed233
Compare
Contributor
Author
|
Fixed the persistence bug we noticed; and replaced TODO comment about backwards compatibility with older registry state files with a comment explaining that we SHOULD retain the compatibility. Otherwise no changes. @cdoern |
Contributor
Author
|
@mergify rebase |
Make it operate with dedicated Process objects; control access to internal registry and process states; provide a number of consistent verbs (load/persist; add/remove; update). This also adds some process module specific test cases that do not rely on running the complete click machinery. These cover the registry and the process class only for now. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Contributor
✅ Branch has been successfully rebased |
booxter
force-pushed
the
general-process-cleanup
branch
from
January 31, 2025 18:26
a2ed233 to
4326f27
Compare
cdoern
approved these changes
Feb 3, 2025
Contributor
|
@alinaryan PTAL |
alinaryan
approved these changes
Feb 4, 2025
alinaryan
left a comment
Contributor
There was a problem hiding this comment.
Nice work! This refactor will help a lot with maintainability
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it operate with the callers via Process objects; control external Process and registry modifications; provide a number of consistent verbs (load/persist; add/remove; update).
This also adds some process module specific test cases that do not rely on running the complete click machinery.
Checklist:
conventional commits.