This repository was archived by the owner on Apr 23, 2026. It is now read-only.
fix: Use lazy import to not impact the CLI layer - #2959
Merged
Conversation
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Contributor
Author
|
@instructlab/core-maintainers @jwm4 one more to fix a minor issue |
cdoern
approved these changes
Jan 22, 2025
cdoern
left a comment
Contributor
There was a problem hiding this comment.
lgtm, I have noticed this log issue with a few other commands, curious as to why this solves it.
jwm4
approved these changes
Jan 22, 2025
jwm4
left a comment
Contributor
There was a problem hiding this comment.
This seems like a good idea.
Contributor
Author
I think it's not loading the dependencies logging these message unless the command is actually executed ( |
dmartinol
marked this pull request as ready for review
January 22, 2025 14:39
nathan-weinberg
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #2957
Changes related to
ingestCLI will be added to #2903Checklist:
conventional commits.