Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

Allow documents to be loaded locally for Knowledge Injection - #2659

Closed
murthyrudra wants to merge 1 commit into
instructlab:mainfrom
murthyrudra:main
Closed

Allow documents to be loaded locally for Knowledge Injection#2659
murthyrudra wants to merge 1 commit into
instructlab:mainfrom
murthyrudra:main

Conversation

@murthyrudra

@murthyrudra murthyrudra commented Nov 15, 2024

Copy link
Copy Markdown
  1. This feature allows users to specify the local folder path instead of github repo for knowledge injection.
  2. This feature required changes in SDG and Schema repositories. The corresponding PRs for the same are here and here

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Rudra
Feature loading documents from local folder for Knowledge
9a4466c 
Signed-off-by: Rudra <rmurthyv@in.ibm.com>
@mergify mergify Bot added the ci-failure PR has at least one CI failure label Nov 15, 2024
@mergify mergify Bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Nov 15, 2024
@cdoern cdoern added the hold In-progress PR. Tag should be removed before merge. label Nov 15, 2024
@cdoern

cdoern commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

thank's for this! Please take a look at instructlab/dev-docs#155 as the discussion there deals with these sorts of functionality changes

@github-actions

github-actions Bot commented Jan 23, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions Bot added the stale label Jan 23, 2025
@github-actions

github-actions Bot commented Feb 23, 2025

Copy link
Copy Markdown

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it!

@github-actions github-actions Bot closed this Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-failure PR has at least one CI failure hold In-progress PR. Tag should be removed before merge. stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@murthyrudra @cdoern