Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

doc: remove "testing doesn't work on Linux" - #1972

Merged
mergify[bot] merged 1 commit into
instructlab:mainfrom
makelinux:linux
Aug 5, 2024
Merged

doc: remove "testing doesn't work on Linux"#1972
mergify[bot] merged 1 commit into
instructlab:mainfrom
makelinux:linux

Conversation

@makelinux

Copy link
Copy Markdown
Contributor

Already supported, see #1337

Already supported, see instructlab#1337

Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
@mergify mergify Bot added the documentation Improvements or additions to documentation label Aug 3, 2024

@booxter booxter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable but I'd love someone with more knowledge about the project support status for Linux to chime in. @cdoern @RobotSail Are there any other features beyond model test not available for Linux at the moment that would justify a "not fully supported" statement?

@danmcp danmcp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change, but the story of what works on Linux vs Mac has become more complicated.

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Aug 3, 2024

@RobotSail RobotSail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
mergify Bot merged commit 3d47ec5 into instructlab:main Aug 5, 2024
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Aug 5, 2024
@makelinux
makelinux deleted the linux branch September 6, 2024 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants