This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Implements --gpus option for eval - #1553
Merged
Merged
Conversation
danmcp
marked this pull request as draft
July 2, 2024 01:34
danmcp
marked this pull request as ready for review
July 2, 2024 15:56
russellb
suggested changes
Jul 2, 2024
nathan-weinberg
previously approved these changes
Jul 2, 2024
nathan-weinberg
left a comment
Contributor
There was a problem hiding this comment.
Pending the discussion this LGTM
nathan-weinberg
previously approved these changes
Jul 2, 2024
russellb
previously requested changes
Jul 2, 2024
russellb
left a comment
Contributor
There was a problem hiding this comment.
one other comment about the config file addition
nathan-weinberg
previously approved these changes
Jul 3, 2024
alimaredia
reviewed
Jul 3, 2024
leseb
reviewed
Jul 3, 2024
leseb
suggested changes
Jul 4, 2024
leseb
left a comment
Contributor
There was a problem hiding this comment.
Please update the CHANGELOG.md. Thanks!
Contributor
Author
Done! |
leseb
previously approved these changes
Jul 5, 2024
leseb
left a comment
Contributor
There was a problem hiding this comment.
Just a thought for later: I hate to see users shooting themselves in the foot, even if the flags empower them to do so. I'm wondering if we should log a warning when someone provides a ridiculously high value for --gpus. This consideration applies to other flags as well.
alimaredia
previously approved these changes
Jul 5, 2024
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
leseb
suggested changes
Jul 8, 2024
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
leseb
approved these changes
Jul 8, 2024
alimaredia
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements --gpus option for evaluate.
Issue resolved by this Pull Request:
Resolves #1549
Checklist:
conventional commits.