This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Add backend configuration and auto-detection support - #1415
Closed
leseb wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
TODO:
|
tiran
reviewed
Jun 18, 2024
russellb
previously approved these changes
Jun 18, 2024
russellb
previously approved these changes
Jun 18, 2024
russellb
previously approved these changes
Jun 18, 2024
leseb
force-pushed
the
add-backend-flag
branch
2 times, most recently
from
June 18, 2024 19:49
a362d5c to
db5f600
Compare
chudegao
approved these changes
Jun 19, 2024
|
|
||
| test_loading_session_history(){ | ||
| ilab serve --max-ctx-size 128 & | ||
| ilab serve --backend llama --max-ctx-size 128 & |
Contributor
There was a problem hiding this comment.
how about use engine instead of backend?
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
leseb
force-pushed
the
add-backend-flag
branch
2 times, most recently
from
June 19, 2024 13:39
a1f6638 to
4697bcb
Compare
tiran
reviewed
Jun 20, 2024
tiran
reviewed
Jun 20, 2024
leseb
force-pushed
the
add-backend-flag
branch
2 times, most recently
from
June 21, 2024 12:57
87c6dfa to
a30a983
Compare
This commit introduces the ability to configure and automatically detect the backend for serving models in InstructLab. One new field, `backend` has been added to the configuration and the CLI to allow users to specify the backend. This field is optional. Additionally, the commit includes the implementation of backend validation and auto-detection based on the model file properties, specifically targeting GGUF file format for now. The `serve` command has been updated to utilize these new configurations and perform backend validation or auto-detection as required. Unit tests for backend validation and changes to the configuration tests to include the new fields are also part of this commit. Co-authored-by: Ali Maredia <amaredia@redhat.com> Signed-off-by: Sébastien Han <seb@redhat.com>
Contributor
Author
|
#1442 contains all of that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to configure and automatically detect
the backend for serving models in InstructLab. One new field,
backendhas been added to the configuration and the CLI to allow users to
specify the backend. This field is optional.
Additionally, the commit includes the implementation of backend validation and
auto-detection based on the model file properties, specifically targeting GGUF
file format for now. The
servecommand has been updated to utilize these newconfigurations and perform backend validation or auto-detection as required.
Unit tests for backend validation and changes to the configuration tests to
include the new fields are also part of this commit.
Co-authored-by: Ali Maredia amaredia@redhat.com
Signed-off-by: Sébastien Han seb@redhat.com
Checklist:
conventional commits.