This repository was archived by the owner on Apr 23, 2026. It is now read-only.
enable local document sources to remove dependency on remote git fetching - #1382
Closed
relyt0925 wants to merge 1 commit into
Closed
enable local document sources to remove dependency on remote git fetching#1382relyt0925 wants to merge 1 commit into
relyt0925 wants to merge 1 commit into
Conversation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
relyt0925
force-pushed
the
local-document-sources
branch
from
June 17, 2024 03:15
cee38ab to
b16ce35
Compare
relyt0925
force-pushed
the
local-document-sources
branch
from
June 17, 2024 03:17
b16ce35 to
378f85a
Compare
Contributor
Author
|
/retest |
relyt0925
force-pushed
the
local-document-sources
branch
from
June 17, 2024 04:05
378f85a to
eade27f
Compare
Currently in the generation process: if any knowledge document or grounded skill is being processed: there is a hard dependency on needing to fetch the documents from the remote git source. For potential private taxonomy sources: this requires the ilab cli git processes to be configured to talk to the private git sources storing the documents. This introduces the ability to add a local document directory in the knowledge or grounded skill directory that can hold all document contents. The SDG process can then read all content from this directory meaning if the content has already been prepulled there is no need to dynmaically reach out to the remote git repo. Signed-off-by: Tyler Lisowski <lisowski@us.ibm.com>
relyt0925
force-pushed
the
local-document-sources
branch
from
June 17, 2024 04:21
eade27f to
5354371
Compare
Contributor
|
I am not sure this is a good idea. See some discussion around knowledge sources in: And any change in knowledge sources would need to be coordinated across the frontend, backend, schema, and taxonomy repos. So such changes should start with a design document in dev-docs to gain consensus on a design which can then be properly documented for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the generation process: if any knowledge document or grounded skill is being processed: there is a hard dependency on needing to fetch the documents from the remote git source. For potential private taxonomy sources: this requires the ilab cli git processes to be configured to talk to the private git sources storing the documents. This introduces the ability to add a local document directory in the knowledge or grounded skill directory that can hold all document contents. The SDG process can then read all content from this directory meaning if the content has already been prepulled there is no need to dynmaically reach out to the remote git repo
Checklist:
conventional commits.