Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

fix: remove --version from subcommands - #1359

Merged
nathan-weinberg merged 1 commit into
instructlab:mainfrom
leseb:rm-version-sub-commands
Jun 14, 2024
Merged

fix: remove --version from subcommands#1359
nathan-weinberg merged 1 commit into
instructlab:mainfrom
leseb:rm-version-sub-commands

Conversation

@leseb

@leseb leseb commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

The --version should be a root option. There is no need to print it in subsequent subcommands.
For instance, it used to be printed here:

$ ilab config --help
Usage: ilab config [OPTIONS] COMMAND [ARGS]...

  Command Group for Interacting with the Config of InstructLab.

  If this is your first time running ilab, it's best to start with `ilab init`
  to create the environment.

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.

We only need ilab --version.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

The `--version` should be a root option. There is no need to print it
in subsequent subcommands.
For instance, it used to be printed here:

```
$ ilab config --help
Usage: ilab config [OPTIONS] COMMAND [ARGS]...

  Command Group for Interacting with the Config of InstructLab.

  If this is your first time running ilab, it's best to start with `ilab init`
  to create the environment.

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.
```

We only need `ilab --version`.

Signed-off-by: Sébastien Han <seb@redhat.com>

@nathan-weinberg nathan-weinberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdoern can you PTAL at this? assume this came from #990 and just want to make sure you can confirm there's no reason for keeping these before merging

@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Jun 14, 2024
@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Jun 14, 2024
@nathan-weinberg
nathan-weinberg merged commit 989b9b7 into instructlab:main Jun 14, 2024
@leseb
leseb deleted the rm-version-sub-commands branch June 17, 2024 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants