This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Handle connection exceptions to chat the model - #1318
Merged
Conversation
liranr23
commented
Jun 10, 2024
leseb
suggested changes
Jun 10, 2024
leseb
approved these changes
Jun 10, 2024
leseb
suggested changes
Jun 11, 2024
leseb
left a comment
Contributor
There was a problem hiding this comment.
One small nit, please fix your commit message: s/excpetions/exceptions/, thanks!
When the server(endpoint) that serves the model is unreachable, we get connection error. Until now we didn't handle this exception, causing a full stack-trace, which can be hard to read and get to the real error. Now, this exception is handled, giving the user the error and a hint of the problem. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
leseb
approved these changes
Jun 11, 2024
nathan-weinberg
approved these changes
Jun 11, 2024
Contributor
|
lets hold changes like this going forward if we can until #990 gets in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server(endpoint) that serves the model is unreachable, we get connection error. Until now we didn't handle this exception, causing a full stack-trace, which can be hard to read and get to the real error. Now, this exception is handled, giving the user the error and a hint of the problem.
Issue resolved by this Pull Request:
Resolves #1310
Checklist:
conventional commits.