Skip to content

Fix for issue 172 - #173

Closed
steveww wants to merge 2 commits into
masterfrom
logging
Closed

Fix for issue 172#173
steveww wants to merge 2 commits into
masterfrom
logging

Conversation

@steveww

@steveww steveww commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

Leave the scope open for downstream error handles and logging instrumentation.

@steveww

steveww commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

New commit should ensure span is closed or left open if there is a downstream handler defined.

@steveww

steveww commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

I think that perhaps the wrapper around handle_user_exception should create a log span so that the error message gets picked up under Log Messages in the UI. WDYT?

@steveww

steveww commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

Any update on this?

@steveww
steveww requested a review from pglombardo July 10, 2019 08:48
@pglombardo

Copy link
Copy Markdown
Contributor

Hi Steve - this probably won't progress until after August 1.

Your use of ._find_error_handler is interesting. Thus far I prefer the approach to fix in #172 but I will test both again when I revisit this. Need to validate the edge cases etc..

@steveww

steveww commented Aug 22, 2019

Copy link
Copy Markdown
Contributor Author

Peter,

Any chance you have time to dig into this and review it?

@pglombardo

Copy link
Copy Markdown
Contributor

Thanks for this @steveww - I put together #172 which has a few more fixes improvements too. Going to close this in favor of #172.

@pglombardo pglombardo closed this Aug 26, 2019
@pglombardo
pglombardo deleted the logging branch August 26, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants