Skip to content

Fix unsanitized user input in OS command execution in Java. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeropath-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unsanitized user input in OS command execution in Java. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01929.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
a1 = "sh";
a2 = "-c";
}
String[] args = {a1, a2, "echo " + bar};
String sanitizedBar = sanitizeInput(bar);
String[] args = {a1, a2, "echo " + sanitizedBar};

ProcessBuilder pb = new ProcessBuilder(args);

Expand All @@ -74,6 +75,11 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
} // end doPost

private static String sanitizeInput(String input) {
// Remove any character that is not alphanumeric or space
return input.replaceAll("[^a-zA-Z0-9 ]", "");
}

private static String doSomething(HttpServletRequest request, String param)
throws ServletException, IOException {

Expand All @@ -84,6 +90,11 @@ private static String doSomething(HttpServletRequest request, String param)
map44.put("keyC", "another-Value"); // put some stuff in the collection
bar = (String) map44.get("keyB-44"); // get it back out

return bar;
return sanitizeInput(bar);
}

private static String sanitizeInput(String input) {
// Remove any character that is not alphanumeric or space
return input.replaceAll("[^a-zA-Z0-9 ]", "");
}
}