Skip to content

Remove 'from __future__ import annotations' in tests#165301

Closed
epenet wants to merge 1 commit intodevfrom
epenet/20260311-0655
Closed

Remove 'from __future__ import annotations' in tests#165301
epenet wants to merge 1 commit intodevfrom
epenet/20260311-0655

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Mar 11, 2026 •
edited
Loading

Proposed change

Based on https://peps.python.org/pep-0649/ and https://peps.python.org/pep-0749/

from __future__ import annotations is no longer needed for forward reference in Python 3.14

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet force-pushed the epenet/20260311-0655 branch from d974c1b to 1fd3824 Compare March 11, 2026 07:40
@epenet epenet marked this pull request as ready for review March 11, 2026 09:28
Copilot AI review requested due to automatic review settings March 11, 2026 09:28
@epenet epenet marked this pull request as draft March 11, 2026 12:42
@epenet epenet marked this pull request as ready for review March 11, 2026 15:15
@epenet epenet marked this pull request as draft March 11, 2026 15:53
@emontnemery
Copy link
Copy Markdown
Contributor

emontnemery commented Mar 11, 2026

Blocked by python/cpython#145756
Let's try this again when we can remove this both from test and implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@thecode thecode thecode approved these changes

@Shulyaka Shulyaka Shulyaka approved these changes

@zweckj zweckj zweckj approved these changes

@chemelli74 chemelli74 chemelli74 approved these changes

@rohankapoorcom rohankapoorcom Awaiting requested review from rohankapoorcom rohankapoorcom is a code owner

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga is a code owner

@puddly puddly Awaiting requested review from puddly puddly is a code owner

@TheJulianJES TheJulianJES Awaiting requested review from TheJulianJES TheJulianJES is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

@gjohansson-ST gjohansson-ST Awaiting requested review from gjohansson-ST gjohansson-ST is a code owner

@synesthesiam synesthesiam Awaiting requested review from synesthesiam synesthesiam is a code owner

@fabaff fabaff Awaiting requested review from fabaff fabaff is a code owner

@frenck frenck Awaiting requested review from frenck frenck is a code owner

@jpbede jpbede Awaiting requested review from jpbede jpbede is a code owner

@MartinHjelmare MartinHjelmare Awaiting requested review from MartinHjelmare MartinHjelmare is a code owner

@raman325 raman325 Awaiting requested review from raman325 raman325 is a code owner

@ludeeus ludeeus Awaiting requested review from ludeeus ludeeus is a code owner

@dgomes dgomes Awaiting requested review from dgomes dgomes is a code owner

@StevenLooman StevenLooman Awaiting requested review from StevenLooman StevenLooman is a code owner

@Kane610 Kane610 Awaiting requested review from Kane610 Kane610 is a code owner

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

@Quentame Quentame Awaiting requested review from Quentame Quentame is a code owner

@hunterjm hunterjm Awaiting requested review from hunterjm hunterjm is a code owner

@uvjustin uvjustin Awaiting requested review from uvjustin uvjustin is a code owner

@allenporter allenporter Awaiting requested review from allenporter allenporter is a code owner

@jjlawren jjlawren Awaiting requested review from jjlawren jjlawren is a code owner

@marcelveldt marcelveldt Awaiting requested review from marcelveldt marcelveldt is a code owner

@bieniu bieniu Awaiting requested review from bieniu bieniu is a code owner

@andrey-git andrey-git Awaiting requested review from andrey-git andrey-git is a code owner

@elupus elupus Awaiting requested review from elupus elupus is a code owner

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

@sairon sairon Awaiting requested review from sairon sairon is a code owner

@CoMPaTech CoMPaTech Awaiting requested review from CoMPaTech CoMPaTech is a code owner

@iMicknl iMicknl Awaiting requested review from iMicknl iMicknl is a code owner

@arturpragacz arturpragacz Awaiting requested review from arturpragacz arturpragacz is a code owner

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@jbouwh jbouwh Awaiting requested review from jbouwh jbouwh is a code owner

@robbiet480 robbiet480 Awaiting requested review from robbiet480 robbiet480 is a code owner

@bachya bachya Awaiting requested review from bachya bachya is a code owner

@farmio farmio Awaiting requested review from farmio farmio is a code owner

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w is a code owner

@ctalkington ctalkington Awaiting requested review from ctalkington ctalkington is a code owner

@mdegat01 mdegat01 Awaiting requested review from mdegat01 mdegat01 is a code owner

@Jc2k Jc2k Awaiting requested review from Jc2k Jc2k is a code owner

@andrewsayre andrewsayre Awaiting requested review from andrewsayre andrewsayre is a code owner

@tronikos tronikos Awaiting requested review from tronikos tronikos is a code owner

@davet2001 davet2001 Awaiting requested review from davet2001 davet2001 is a code owner

@cgarwood cgarwood Awaiting requested review from cgarwood cgarwood is a code owner

@zxdavb zxdavb Awaiting requested review from zxdavb zxdavb is a code owner

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz is a code owner

@kbx81 kbx81 Awaiting requested review from kbx81 kbx81 is a code owner

@Ernst79 Ernst79 Awaiting requested review from Ernst79 Ernst79 is a code owner

@ochlocracy ochlocracy Awaiting requested review from ochlocracy ochlocracy is a code owner

@erwindouna erwindouna Awaiting requested review from erwindouna erwindouna will be requested when the pull request is marked ready for review erwindouna is a code owner

Assignees

No one assigned

Labels

cla-signed code-quality core has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@epenet @emontnemery @thecode @Shulyaka @zweckj @chemelli74