This repository was archived by the owner on Sep 6, 2025. It is now read-only.
Add 7.1 compatibility - #9
Merged
Merged
Conversation
nenad
force-pushed
the
php71-compatibility
branch
from
May 24, 2017 13:43
cac2265 to
b4a9c8d
Compare
nenad
force-pushed
the
php71-compatibility
branch
from
May 24, 2017 13:55
b4a9c8d to
160905f
Compare
Contributor
|
👍 I still 😢 that you didn't up the required PHP version |
|
👍 |
sergiught
reviewed
May 24, 2017
| public function __construct(\DateTimeInterface $dateTime = null) | ||
| { | ||
| $this->occurredOn = new \DateTime(); | ||
| $this->occurredOn = $dateTime === null ? $dateTime : new \DateTime(); |
There was a problem hiding this comment.
Why not use the new php 7 null coalesce operator here as well?
$dateTime ?? new \DateTime();
Author
There was a problem hiding this comment.
This needs to be compatible with php 5.6
|
👍 |
|
👍 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes: