Skip to content
This repository was archived by the owner on Sep 6, 2025. It is now read-only.

[IMR-927]: Bump beberlei/assert so that we can update dependencies in products-service - #14

Merged
nhatthm merged 1 commit into
masterfrom
feature/IMR-927-bump-dependencies
Aug 14, 2019
Merged

[IMR-927]: Bump beberlei/assert so that we can update dependencies in products-service#14
nhatthm merged 1 commit into
masterfrom
feature/IMR-927-bump-dependencies

Conversation

@nhatthm

@nhatthm nhatthm commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

Ticket

Description

We want to update the dependencies for products-service. Unfortunately, I need to update this first

This change is safe, I already cross checked the dependencies of beberlei/assert. Also checked the usage in this project, we only use it 1 place

image

References

@nhatthm nhatthm added the dev_qa label Aug 14, 2019
@vearutop

vearutop commented Aug 14, 2019

Copy link
Copy Markdown

+1

Approved with Zappr Approved with Zappr

@nhatthm
nhatthm force-pushed the feature/IMR-927-bump-dependencies branch from 07a189c to f1d2822 Compare August 14, 2019 15:35
@vearutop

vearutop commented Aug 14, 2019

Copy link
Copy Markdown

+1

Approved with Zappr Approved with Zappr

@nhatthm
nhatthm force-pushed the feature/IMR-927-bump-dependencies branch from f1d2822 to b5abdc9 Compare August 14, 2019 15:39
@codecov

codecov Bot commented Aug 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #14 into master will decrease coverage by 2.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #14      +/-   ##
==========================================
- Coverage      60.9%    58%   -2.91%     
+ Complexity      337    332       -5     
==========================================
  Files            46     46              
  Lines          1059   1031      -28     
==========================================
- Hits            645    598      -47     
- Misses          414    433      +19
Impacted Files Coverage Δ Complexity Δ
src/EventStore/Adapter/MongoAdapter.php 0% <0%> (-76.93%) 8% <0%> (ø)
src/EventSourcing/AggregateRepositoryFactory.php 62.5% <0%> (-6.74%) 11% <0%> (ø)
src/EventStore/Adapter/EventProcessorTrait.php 95% <0%> (-0.24%) 5% <0%> (ø)
src/EventStore/Adapter/InMemoryAdapter.php 94.11% <0%> (-0.17%) 10% <0%> (-1%)
src/EventSourcing/AggregateRepository.php 97.14% <0%> (-0.08%) 12% <0%> (-2%)
...entStore/Snapshot/Adapter/RedisSnapshotAdapter.php 97.5% <0%> (-0.07%) 7% <0%> (ø)
src/EventBus/SimpleEventBus.php 100% <0%> (ø) 7% <0%> (-2%) ⬇️
src/Serializer/Type/VectorHandler.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
...tStore/Snapshot/Adapter/SnapshotProcessorTrait.php 100% <0%> (ø) 3% <0%> (ø) ⬇️
src/Serializer/Type/UuidSerializerHandler.php 18.91% <0%> (+1.41%) 12% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cd25c...b5abdc9. Read the comment docs.

@vearutop

vearutop commented Aug 14, 2019

Copy link
Copy Markdown

+1

Approved with Zappr Approved with Zappr

@nhatthm
nhatthm merged commit 17c75ab into master Aug 14, 2019
@nhatthm
nhatthm deleted the feature/IMR-927-bump-dependencies branch August 14, 2019 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants