Add msg direction for CAN-FD in BlfReader - #966
Merged
mergify[bot] merged 5 commits intoJun 8, 2021
Merged
Conversation
christiansandberg
approved these changes
Jan 10, 2021
Owner
|
Once the tests pass (will require updating to reflect the rx direction) this will automerge. |
pierreluctg
approved these changes
Jan 14, 2021
Collaborator
|
Is someone planning to adjust the failing |
Collaborator
|
It would be great to get this included in the 4.0.0 release, but one would have to very slightly change the testing code. See here: https://travis-ci.com/github/hardbyte/python-can/jobs/469807838#L898 |
Contributor
Author
|
I fixed the test and now everything should pass :) |
Codecov Report
@@ Coverage Diff @@
## develop #966 +/- ##
===========================================
- Coverage 68.66% 68.65% -0.01%
===========================================
Files 79 79
Lines 7620 7619 -1
===========================================
- Hits 5232 5231 -1
Misses 2388 2388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965