Skip to content

Fix deprecation of asyncio.get_event_loop() - #1235

Merged
zariiii9003 merged 15 commits into
developfrom
fix-deprecation-asyncio-get_event_loop
Jan 27, 2022
Merged

Fix deprecation of asyncio.get_event_loop()#1235
zariiii9003 merged 15 commits into
developfrom
fix-deprecation-asyncio-get_event_loop

Conversation

@felixdivo

@felixdivo felixdivo commented Jan 27, 2022

Copy link
Copy Markdown
Collaborator

Part of #1230.

Also improves some examples, documentation and Notifier tests.

@felixdivo felixdivo added minor QA about improving and maintaining the quality of the library labels Jan 27, 2022
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 27, 2022
@felixdivo felixdivo self-assigned this Jan 27, 2022
@codecov

codecov Bot commented Jan 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1235 (43a066e) into develop (f1808ed) will increase coverage by 0.03%.
The diff coverage is 72.72%.

@@             Coverage Diff             @@
##           develop    #1235      +/-   ##
===========================================
+ Coverage    65.88%   65.92%   +0.03%     
===========================================
  Files           86       86              
  Lines         8884     8885       +1     
===========================================
+ Hits          5853     5857       +4     
+ Misses        3031     3028       -3     

@felixdivo
felixdivo marked this pull request as draft January 27, 2022 07:27
@felixdivo

felixdivo commented Jan 27, 2022

Copy link
Copy Markdown
Collaborator Author

How did this happen ...?

EDIT: Appears to have been a single incident. I'll ignore it.

@felixdivo
felixdivo marked this pull request as ready for review January 27, 2022 13:56
@felixdivo

Copy link
Copy Markdown
Collaborator Author

The remaining pylint errors are unrelated so I'd open a new PR after this one.

@felixdivo
felixdivo requested a review from zariiii9003 January 27, 2022 13:58
Comment thread can/notifier.py Outdated
@felixdivo

Copy link
Copy Markdown
Collaborator Author

@zariiii9003 Feel free to (squash-)merge if you like this more.

@zariiii9003
zariiii9003 merged commit 48f9c27 into develop Jan 27, 2022
@mergify
mergify Bot deleted the fix-deprecation-asyncio-get_event_loop branch January 27, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor QA about improving and maintaining the quality of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants