Conversation
rjchee
reviewed
Oct 27, 2017
| elif val == 'challenges': | ||
| return challenges(request) | ||
| else: | ||
| return render_template('form.html') |
Collaborator
There was a problem hiding this comment.
why is this indentation so weird
Contributor
Author
There was a problem hiding this comment.
I don't see that in my code... rip. I'll reindent
rjchee
reviewed
Oct 27, 2017
| "chip_keywords": [ | ||
| "REST", | ||
| "banking", | ||
| "REST", |
rjchee
reviewed
Oct 27, 2017
| 'image': request.form.get('image'), | ||
| 'description': request.form.get('description'), | ||
| 'link': request.form.get('link'), | ||
| 'keywords': request.form.get('search_keywords').split(','), |
Collaborator
There was a problem hiding this comment.
[keyword.strip() for keyword in request.form.get('search_keywords').split(',')] so we can do split on comma-space as well as comma
rjchee
reviewed
Oct 27, 2017
| 'name':request.form.get('company_name'), | ||
| 'image': request.form.get('image'), | ||
| 'link': request.form.get('link'), | ||
| 'keywords': request.form.get('search_keywords').split(','), |
Collaborator
There was a problem hiding this comment.
same here and for the chip keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.